PR comments

aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/AWSCognitoAuthPlugin.kt

@@ -33,7 +33,7 @@ import com.amplifyframework.auth.AuthUser
 import com.amplifyframework.auth.AuthUserAttribute
 import com.amplifyframework.auth.AuthUserAttributeKey
 import com.amplifyframework.auth.cognito.asf.UserContextDataProvider
-import com.amplifyframework.auth.cognito.options.AWSCognitoAuthVerifyTOTPSetupOptions
+import com.amplifyframework.auth.cognito.options.AWSAuthVerifyTOTPSetupOptions
 import com.amplifyframework.auth.cognito.options.FederateToIdentityPoolOptions
 import com.amplifyframework.auth.cognito.result.FederateToIdentityPoolResult
 import com.amplifyframework.auth.exceptions.ConfigurationException
@@ -775,7 +775,7 @@ class AWSCognitoAuthPlugin : AuthPlugin<AWSCognitoAuthService>() {
         queueChannel.trySend(
             pluginScope.launch(start = CoroutineStart.LAZY) {
                 try {
-                    val result = queueFacade.setupMFA()
+                    val result = queueFacade.setUpTOTP()
                     onSuccess.accept(result)
                 } catch (e: Exception) {
                     onError.accept(e.toAuthException())
@@ -785,7 +785,7 @@ class AWSCognitoAuthPlugin : AuthPlugin<AWSCognitoAuthService>() {
     }
 
     override fun verifyTOTPSetup(code: String, onSuccess: Action, onError: Consumer<AuthException>) {
-        verifyTOTPSetup(code, AWSCognitoAuthVerifyTOTPSetupOptions.CognitoBuilder().build(), onSuccess, onError)
+        verifyTOTPSetup(code, AWSAuthVerifyTOTPSetupOptions.CognitoBuilder().build(), onSuccess, onError)
     }
 
     override fun verifyTOTPSetup(

aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/CognitoAuthExceptionConverter.kt

@@ -91,7 +91,7 @@ internal class CognitoAuthExceptionConverter {
                 is PasswordResetRequiredException ->
                     com.amplifyframework.auth.cognito.exceptions.service.PasswordResetRequiredException(error)
                 is EnableSoftwareTokenMfaException ->
-                    com.amplifyframework.auth.cognito.exceptions.service.EnableSoftwareTokenMfaException(error)
+                    com.amplifyframework.auth.cognito.exceptions.service.EnableSoftwareTokenMFAException(error)
                 is UserLambdaValidationException ->
                     com.amplifyframework.auth.cognito.exceptions.service.UserLambdaValidationException(
                         error.message,

aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/KotlinAuthFacadeInternal.kt

@@ -523,7 +523,7 @@ internal class KotlinAuthFacadeInternal(private val delegate: RealAWSCognitoAuth
         }
     }
 
-    suspend fun setupMFA(): TOTPSetupDetails {
+    suspend fun setUpTOTP(): TOTPSetupDetails {
         return suspendCoroutine { continuation ->
             delegate.setUpTOTP(
                 { continuation.resume(it) },

aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/RealAWSCognitoAuthPlugin.kt

@@ -80,7 +80,7 @@ import com.amplifyframework.auth.cognito.options.AWSCognitoAuthSignOutOptions
 import com.amplifyframework.auth.cognito.options.AWSCognitoAuthSignUpOptions
 import com.amplifyframework.auth.cognito.options.AWSCognitoAuthUpdateUserAttributeOptions
 import com.amplifyframework.auth.cognito.options.AWSCognitoAuthUpdateUserAttributesOptions
-import com.amplifyframework.auth.cognito.options.AWSCognitoAuthVerifyTOTPSetupOptions
+import com.amplifyframework.auth.cognito.options.AWSAuthVerifyTOTPSetupOptions
 import com.amplifyframework.auth.cognito.options.AWSCognitoAuthWebUISignInOptions
 import com.amplifyframework.auth.cognito.options.AuthFlowType
 import com.amplifyframework.auth.cognito.options.FederateToIdentityPoolOptions
@@ -2167,7 +2167,7 @@ internal class RealAWSCognitoAuthPlugin(
         onSuccess: Action,
         onError: Consumer<AuthException>
     ) {
-        val cognitoOptions = options as? AWSCognitoAuthVerifyTOTPSetupOptions
+        val cognitoOptions = options as? AWSAuthVerifyTOTPSetupOptions
         verifyTotp(code, cognitoOptions?.friendlyDeviceName, onSuccess, onError)
     }
 

aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/exceptions/service/EnableSoftwareTokenMfaException.kt → aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/exceptions/service/EnableSoftwareTokenMFAException.kt

@@ -20,7 +20,7 @@ import com.amplifyframework.auth.AuthException
  * Software Token MFA is not enabled for the user.
  * @param cause The underlying cause of this exception
  */
-open class EnableSoftwareTokenMfaException(cause: Throwable?) :
+open class EnableSoftwareTokenMFAException(cause: Throwable?) :
     AuthException(
         "Software token TOTP multi-factor authentication (MFA) is not enabled for the user pool.",
         "Enable the software token MFA for the user.",

aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/options/AWSCognitoAuthVerifyTOTPSetupOptions.java → aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/options/AWSAuthVerifyTOTPSetupOptions.java

@@ -20,11 +20,11 @@
 /**
  * Cognito extension of update verify totp setup options to add the platform specific fields.
  */
-public final class AWSCognitoAuthVerifyTOTPSetupOptions extends AuthVerifyTOTPSetupOptions {
+public final class AWSAuthVerifyTOTPSetupOptions extends AuthVerifyTOTPSetupOptions {
 
     private String friendlyDeviceName;
 
-    private AWSCognitoAuthVerifyTOTPSetupOptions(String friendlyDeviceName) {
+    private AWSAuthVerifyTOTPSetupOptions(String friendlyDeviceName) {
         this.friendlyDeviceName = friendlyDeviceName;
     }
 
@@ -42,16 +42,12 @@ public String getFriendlyDeviceName() {
     public static final class CognitoBuilder extends Builder<CognitoBuilder> {
         private String friendlyDeviceName;
 
-        private String getFriendlyDeviceName() {
-            return friendlyDeviceName;
-        }
-
         /**
          * Friendly device name to be set in Cognito.
          * @param friendlyDeviceName String input for friendlyDeviceName
          * @return current CognitoBuilder instance
          * */
-        public CognitoBuilder setFriendlyDeviceName(String friendlyDeviceName) {
+        public CognitoBuilder friendlyDeviceName(String friendlyDeviceName) {
             this.friendlyDeviceName = friendlyDeviceName;
             return this;
         }
@@ -60,8 +56,8 @@ public CognitoBuilder setFriendlyDeviceName(String friendlyDeviceName) {
          * Construct and return the object with the values set in the builder.
          * @return a new instance of AWSCognitoAuthVerifyTOTPSetupOptions with the values specified in the builder.
          */
-        public AWSCognitoAuthVerifyTOTPSetupOptions build() {
-            return new AWSCognitoAuthVerifyTOTPSetupOptions(getFriendlyDeviceName());
+        public AWSAuthVerifyTOTPSetupOptions build() {
+            return new AWSAuthVerifyTOTPSetupOptions(friendlyDeviceName);
         }
     }
 }

aws-auth-cognito/src/test/java/com/amplifyframework/auth/cognito/AWSCognitoAuthPluginTest.kt

@@ -26,7 +26,7 @@ import com.amplifyframework.auth.AuthSession
 import com.amplifyframework.auth.AuthUser
 import com.amplifyframework.auth.AuthUserAttribute
 import com.amplifyframework.auth.AuthUserAttributeKey
-import com.amplifyframework.auth.cognito.options.AWSCognitoAuthVerifyTOTPSetupOptions
+import com.amplifyframework.auth.cognito.options.AWSAuthVerifyTOTPSetupOptions
 import com.amplifyframework.auth.cognito.options.FederateToIdentityPoolOptions
 import com.amplifyframework.auth.cognito.result.FederateToIdentityPoolResult
 import com.amplifyframework.auth.options.AuthConfirmResetPasswordOptions
@@ -703,7 +703,7 @@ class AWSCognitoAuthPluginTest {
     @Test
     fun verifyTOTPSetupWithOptions() {
         val code = "123456"
-        val options = AWSCognitoAuthVerifyTOTPSetupOptions.CognitoBuilder().setFriendlyDeviceName("DEVICE_NAME").build()
+        val options = AWSAuthVerifyTOTPSetupOptions.CognitoBuilder().friendlyDeviceName("DEVICE_NAME").build()
         val expectedOnSuccess = Action { }
         val expectedOnError = Consumer<AuthException> { }
         authPlugin.verifyTOTPSetup(code, options, expectedOnSuccess, expectedOnError)

aws-auth-cognito/src/test/java/com/amplifyframework/auth/cognito/RealAWSCognitoAuthPluginTest.kt

@@ -63,7 +63,7 @@ import com.amplifyframework.auth.cognito.options.AWSCognitoAuthResendUserAttribu
 import com.amplifyframework.auth.cognito.options.AWSCognitoAuthSignInOptions
 import com.amplifyframework.auth.cognito.options.AWSCognitoAuthUpdateUserAttributeOptions
 import com.amplifyframework.auth.cognito.options.AWSCognitoAuthUpdateUserAttributesOptions
-import com.amplifyframework.auth.cognito.options.AWSCognitoAuthVerifyTOTPSetupOptions
+import com.amplifyframework.auth.cognito.options.AWSAuthVerifyTOTPSetupOptions
 import com.amplifyframework.auth.cognito.options.AuthFlowType
 import com.amplifyframework.auth.cognito.usecases.ResetPasswordUseCase
 import com.amplifyframework.auth.exceptions.InvalidStateException
@@ -1736,7 +1736,7 @@ class RealAWSCognitoAuthPluginTest {
 
         plugin.verifyTOTPSetup(
             code,
-            AWSCognitoAuthVerifyTOTPSetupOptions.CognitoBuilder().setFriendlyDeviceName(friendlyDeviceName).build(),
+            AWSAuthVerifyTOTPSetupOptions.CognitoBuilder().friendlyDeviceName(friendlyDeviceName).build(),
             onSuccess,
             onError
         )
@@ -1781,7 +1781,7 @@ class RealAWSCognitoAuthPluginTest {
 
         plugin.verifyTOTPSetup(
             code,
-            AWSCognitoAuthVerifyTOTPSetupOptions.CognitoBuilder().build(),
+            AWSAuthVerifyTOTPSetupOptions.CognitoBuilder().build(),
             onSuccess,
             onError
         )

core-kotlin/src/main/java/com/amplifyframework/kotlin/auth/Auth.kt

@@ -334,13 +334,15 @@ interface Auth {
      * Setup TOTP for the currently signed in user.
      * @return TOTP Setup details
      */
+    @Throws(AuthException::class)
     suspend fun setUpTOTP(): TOTPSetupDetails
 
     /**
      * Verify TOTP setup for the currently signed in user.
      * @param code TOTP code to verify TOTP setup
      * @param options additional options to verify totp setup
      */
+    @Throws(AuthException::class)
     suspend fun verifyTOTPSetup(
         code: String,
         options: AuthVerifyTOTPSetupOptions = AuthVerifyTOTPSetupOptions.builder().build()

core/src/main/java/com/amplifyframework/TOTPSetupDetails.kt

@@ -21,9 +21,9 @@ data class TOTPSetupDetails(
     val username: String
 ) {
     fun getSetupURI(
-        appName: String,
+        issuer: String,
         accountName: String = username
     ): Uri {
-        return Uri.parse("otpauth://totp/$appName:$accountName?secret=$sharedSecret&issuer=$appName")
+        return Uri.parse("otpauth://totp/$issuer:$accountName?secret=$sharedSecret&issuer=$issuer")
     }
 }