fix(aws-sdk): exception handling & test coverage #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes: aws-actions#136 Unintended exception mishandling after v3 sdk change * Upgrades test coverage to 100% statement/function/branch/line * Requires 100% coverage in jest * Ignore coverage for defaulting of GITHUB_WORKSPACE due to implications of test file locations during testing * Retypes CreateStackCommandInput to affirm presence of StackName which is required, and previously asserted by core.getInput() * Adds dependency on @smithy/node-http-handler which is used in src/main.ts but not declared as a dependency, depending on hoisting when installed by @aws-sdk/client-cloudformation (consider using pnpm instead of npm to avoid this in future?)
kddejong
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #136 Unintended exception mishandling after v3 sdk change
Description:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.