Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds env-files input to the github action #235

Merged
merged 5 commits into from
May 10, 2024

Conversation

bmbferreira
Copy link
Contributor

Description of changes:

Adds the env-files input to the github action to be possible to pass env files into the task definition as described here: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/taskdef-envfiles.html

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bmbferreira
Copy link
Contributor Author

@iamhopaul123 sorry to ping you, but I have this PR open for a long time... Is this action still maintained by AWS or should I keep using my fork with this fix? Thanks

@bmbferreira
Copy link
Contributor Author

@iamhopaul123 I just fixed the conflicts on this PR. Also noticed you merged #284 3 days ago. Is thera anything missing on this PR? Would love to see it merged, since I've been using my fork for more than 1 year now because I really need to set the environmentFiles on the task. Thanks in advance.

@rdhar
Copy link

rdhar commented May 8, 2024

Would be great to have this as it greatly improves upon how easily env vars can be populated in bulk within CICD workflows.

@bmbferreira
Copy link
Contributor Author

bmbferreira commented May 8, 2024

nice, now I have conflicts again... @iamhopaul123 @clareliguori @Lou1415926 anyone from AWS please answer... this github action is used by 26.9k users according to github stats and seems there's multiple users interested in having the env-files as input on the github action. What's blocking this PR to be merged? I can fix the conflicts again, but can you guarantee that this will be merged afterwards? Otherwise I'll just be wasting my time again 🤷‍♂️ Thank you.

@amazreech
Copy link
Contributor

Hi @bmbferreira !

Thank a lot of for your contribution. Apologies for the delayed response. We will be working on this issue. Would be great if you could do following steps for now:

  1. Update the PR title to conventional commits to feat: adds env-files input to the github action
  2. Fix the conflicts

@bmbferreira bmbferreira changed the title adds env-files input to the github action feat: adds env-files input to the github action May 9, 2024
@bmbferreira
Copy link
Contributor Author

@amazreech thanks for replying! 🙇 just changed the PR title and fixed the conflicts. Please let me know if you need anything else to get this approved and merged. Thank you!

Copy link
Contributor

@amazreech amazreech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changes looks good!

@rdhar
Copy link

rdhar commented May 10, 2024

Fantastic to see momentum pick up around this GH Action again, releasing small yet very meaningful updates -- no less, contributed by members of the community!

@amazreech amazreech merged commit a40f6ea into aws-actions:master May 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants