Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expected params.forceNewDeployment to be a boolean #157

Closed
dili91 opened this issue Jan 11, 2021 · 6 comments · Fixed by #159
Closed

Expected params.forceNewDeployment to be a boolean #157

dili91 opened this issue Jan 11, 2021 · 6 comments · Fixed by #159
Assignees
@paragbhingre
Labels
bug Something isn't working

Comments

@dili91
Copy link

dili91 commented Jan 11, 2021

Is this issue solved ? i'm still getting that with 1.4.1.

Run aws-actions/[email protected]
  with:
    task-definition: /home/runner/work/_temp/task-definition--435-nD4dXDjs371k-.json
    cluster: ef-stg-cluster
    service: ef-stg-service
    force-new-deployment: true
  env:
    AWS_DEFAULT_REGION: ***
    AWS_REGION: ***
    AWS_ACCESS_KEY_ID: ***
    AWS_SECRET_ACCESS_KEY: ***
Error: Expected params.forceNewDeployment to be a boolean
yehudacohen added a commit to yehudacohen/amazon-ecs-deploy-task-definition that referenced this issue Jan 12, 2021
@yehudacohen
Fix forceNewDeployment for ECS Task. Fixes: aws-actions#157
4dd0dd3
yehudacohen added a commit to yehudacohen/amazon-ecs-deploy-task-definition that referenced this issue Jan 12, 2021
@yehudacohen
fix: enable forceNewDeployment for ECS Task that is broken per aws-ac…
c4cc673 
…tions#157
@dili91
Copy link
Author

dili91 commented Jan 13, 2021

thanks @yehuda-elementryx !
looking forward to a new release 🙏

@atellezsazo
Copy link

@yehuda-elementryx! I tried your fork, it's still having the problem :(

@yehudacohen
Copy link
Contributor

Hi @atellezsazo what does your config look like? I unit tested with force-new-deployment: 'true' with the quotation marks to make it a string, but not sure that my test was comprehensive. I definitely didn't test with force-new-deployment having a boolean value.

@allisaurus allisaurus added the bug Something isn't working label Jan 22, 2021
@dili91
Copy link
Author

dili91 commented Jan 23, 2021

As suggested on the PR itself, I'd keep it simple and accept only boolean values there :)

yehudacohen added a commit to yehudacohen/amazon-ecs-deploy-task-definition that referenced this issue Jan 24, 2021
@yehudacohen
fix: enable forceNewDeployment for ECS Task that is broken per aws-ac…
c36a5f7 
…tions#157
yehudacohen added a commit to yehudacohen/amazon-ecs-deploy-task-definition that referenced this issue Jan 24, 2021
@yehudacohen
fix: enable forceNewDeployment for ECS Task that is broken per aws-ac…
50925f5 
…tions#157
mergify bot added a commit that referenced this issue Jan 28, 2021
@yehudacohen @mergify
fix: enable forceNewDeployment for ECS Task that is broken per #157 (#…
4b6d445 
…159)

Co-authored-by: yehuda-elementryx <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@paragbhingre paragbhingre mentioned this issue Jan 28, 2021
Merged
@piradeepk piradeepk reopened this Feb 1, 2021
@piradeepk piradeepk added the pending-release The change has been merged and is awaiting a release label Feb 1, 2021
@kaka-ruto
Copy link

Having the same issue. Looking forward to the release.

@piradeepk piradeepk removed the pending-release The change has been merged and is awaiting a release label Feb 9, 2021
@piradeepk
Copy link
Contributor

Closing as this was released yesterday (02/08)

s3cube pushed a commit that referenced this issue Jul 16, 2024
@dependabot
chore: Bump eslint from 8.10.0 to 8.11.0 (#157)
8a6a158 
Bumps [eslint](https://github.com/eslint/eslint) from 8.10.0 to 8.11.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.10.0...v8.11.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paragbhingre paragbhingre

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: forceNewDeployment to be a boolean. yehudacohen/amazon-ecs-deploy-task-definition
7 participants
@atellezsazo @dili91 @kaka-ruto @paragbhingre @allisaurus @yehudacohen @piradeepk