Fix: Void tag followed by any non-whitespace character duplicates closing > #14
Conversation
Prettier always adds a newline after `<col>`, `<hr>`, `<param>`, `<source>` and `<track>` elements, no matter what comes after them. Relates to awmottaz#10
(Probably) brittle solution. TypeScript doesn't recognise the `path.node.prev` property. Relates to awmottaz#10
`<br>` triggers a special case where an extra newline is added
|
Polite nudge @awmottaz :) |
|
Yes, sorry, thanks for being patient. Life happens 😅 I do want to look at this very soon! Haven't lost track of it |
|
Any updates on this? This plugin will be very useful since Svelte removed self-closing tags due to it being incompatible with HTML. sveltejs/svelte#11052 |
|
Apologies for being so slow here — it's still on my radar, just haven't found the time to verify @f11xter 's fix yet. |
|
@f11xter omg thank you for waiting on this! I am finally finding some time to look more deeply at this PR. I have a couple questions, I'll drop comments on the diff. In the meantime, I just released v1.6.0 of this plugin. Would you mind updating your branch to the latest from |
| { el: "area", hasTrailingNewline: false }, | ||
| { el: "base", hasTrailingNewline: false }, | ||
| { el: "br", hasTrailingNewline: false }, | ||
| { el: "col", hasTrailingNewline: true }, | ||
| { el: "embed", hasTrailingNewline: false }, | ||
| { el: "hr", hasTrailingNewline: true }, | ||
| { el: "img", hasTrailingNewline: false }, | ||
| { el: "input", hasTrailingNewline: false }, | ||
| { el: "link", hasTrailingNewline: false }, | ||
| { el: "meta", hasTrailingNewline: false }, | ||
| { el: "param", hasTrailingNewline: true }, | ||
| { el: "source", hasTrailingNewline: true }, | ||
| { el: "track", hasTrailingNewline: true }, | ||
| { el: "wbr", hasTrailingNewline: false }, |
There was a problem hiding this comment.
How is hasTrailingNewline determined for each tag? Is this defined in the Prettier source somewhere?
There was a problem hiding this comment.
Tbh I don't remember how I figured that out, but there's a decent probability it was just through running prettier without the plugin and observing the results.
I think the answer lies in printChildren's call to printBetweenLine but I've failed to trace it through to that conclusion.
There was a problem hiding this comment.
Okay, no worries. I'll just add a comment here saying something like that
|
Thanks again @f11xter — I'm ready to approve and merge this thing, looks like you just need to fix the linting issue (you can run |
|
Thank you so much for looking at this and I'm glad to have helped :) |
<br>→<br) if next element borrows itisSelfClosing = trueafter printing to prevent parent from adding unwanted line breaksisSelfClosing = falseto prevent adding/>to void elementCloses #10