Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SiYuan #878

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add SiYuan #878

wants to merge 2 commits into from

Conversation

TornaxO7
Copy link

Thanks for taking the time to suggest an addition to awesome-selfhosted!

To ensure your Pull Request is dealt with swiftly, please check the following (check the boxes [x]):

  • Submit one item per pull request. This eases reviewing and speeds up inclusion.
  • You have searched the repository for any relevant issues or PRs, including closed ones.
  • Any software you are adding is not already listed at any of awesome-sysadmin, staticgen.com, staticsitegenerators.net, dbdb.io.
  • The file you are adding is formatted as described in addition.md.
  • Demo links should only be used for interactive demos, i.e. not video demonstrations.
  • Comments and unused optional fields have been removed.
  • The file you are adding uses kebab-case file naming, for example my-awesome-software.yml.
  • Values for platform are the main server-side requirements for the software. Don't include frameworks or specific dialects.
  • Any software project you are adding to the list is actively maintained.
  • Any software project you are adding was first released more than 4 months ago.
  • Any software project you are adding has working installation instructions.
  • You understand that your Pull Request will be merged ~1 week after approval, to allow for further comments if needed.

@nodiscc nodiscc added addition Adding new software to the list reviewers wanted Awaiting reviews labels Sep 29, 2024
kokomo123
kokomo123 reviewed Sep 30, 2024
View reviewed changes
software/siyuan.yml Outdated Show resolved Hide resolved
@nodiscc nodiscc added the feedback needed Awaiting feedback/changes by the submitter label Oct 27, 2024
@TornaxO7 @kokomo123
Update software/siyuan.yml
30d4f5c 
Shorten the description

Co-authored-by: kokomo123 <[email protected]>
@kokomo123 kokomo123 removed the feedback needed Awaiting feedback/changes by the submitter label Nov 1, 2024
kokomo123
kokomo123 approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@kokomo123 kokomo123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with all things considered, LGTM.

@nodiscc nodiscc removed the reviewers wanted Awaiting reviews label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokomo123 kokomo123 kokomo123 approved these changes

@Rabenherz112 Rabenherz112 Rabenherz112 approved these changes

@nodiscc nodiscc nodiscc approved these changes

Assignees
No one assigned
Labels
addition Adding new software to the list
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TornaxO7 @nodiscc @Rabenherz112 @kokomo123