Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthie: "Create appointment" action should use date action field for appointment date #217

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

nckhell
Copy link
Contributor

@nckhell nckhell commented Aug 21, 2023

Was a string previously which resulted in users not being able to select date data points for the appointment date.

@nckhell
Copy link
Contributor Author

nckhell commented Aug 21, 2023

@ebomcke-awell I need some help to check whether this is actually a breaking change or not. Or are we good now that we have the refresh mechanism?

@nckhell nckhell changed the title Healthie: "Create appointment" action should accept use date action field for appointment date Healthie: "Create appointment" action should use date action field for appointment date Aug 21, 2023
@ebomcke-awell
Copy link
Contributor

@ebomcke-awell I need some help to check whether this is actually a breaking change or not. Or are we good now that we have the refresh mechanism?

Important context: I checked in Sandbox, Production EU & US and there is no published care flow that uses the createAppointment action of the healthie extension.

Are changes to fields covered by the extension refresh mechanism ?
Yes. Refreshing the extension automatically refreshes the list of fields of each healthie action configured in the care flow, preserving the value if possible.

What if there were published care flows? How would they be impacted ?
Orchestration does not know that the field has changed, so it will compute the value of the field using the configuration dating from when the care flow was published. The value is then serialised into a string before it gets sent to the extension (all field values are sent in the serialised string form). Given that the extension code handles the deserialisation, it also has to include the appropriate fallback mechanism in case of a changed field to make sure no breaking change is introduced.

In this specific case the change of datetime from type = FieldType.STRING to type = FieldType.DATE is not a breaking change as the serialised value of datetime (so in string form) is sent straight to Healthie without any processing.

@nckhell nckhell merged commit 3cbe5ce into main Aug 22, 2023
1 check passed
@nckhell nckhell deleted the healthie_create_appt_should_work_with_dates branch August 22, 2023 15:17
nckhell added a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants