fix what id we pass (#520)

awell-health · Nov 13, 2024 · dcfe647 · dcfe647
1 parent c33b982
commit dcfe647
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/...ns/healthie/actions/dataExchange/pushFormResponseToHealthie/pushFormResponseToHealthie.ts b/...ns/healthie/actions/dataExchange/pushFormResponseToHealthie/pushFormResponseToHealthie.ts
@@ -82,17 +82,19 @@ export const pushFormResponseToHealthie: Action<
           },
         },
       })
+      const formAnswerGroupId =
+        res?.createFormAnswerGroup?.form_answer_group?.id
 
-      if (isEmpty(res?.createFormAnswerGroup?.form_answer_group?.id))
+      if (isEmpty(formAnswerGroupId))
         throw new HealthieFormResponseNotCreated(res)
 
       // separate call to lock the form if needed
-      if (lock) {
+      if (lock && formAnswerGroupId !== undefined) {
         await healthieSdk.client.mutation({
           lockFormAnswerGroup: {
             __args: {
               input: {
-                id: fields.healthieFormId,
+                id: formAnswerGroupId,
               },
             },
             form_answer_group: {
@@ -104,9 +106,7 @@ export const pushFormResponseToHealthie: Action<
 
       await onComplete({
         data_points: {
-          formAnswerGroupId: String(
-            res.createFormAnswerGroup?.form_answer_group?.id
-          ),
+          formAnswerGroupId: String(formAnswerGroupId),
         },
         events: getSubActivityLogs(omittedFormAnswers),
       })

diff --git a/.../healthie/actions/dataExchange/pushFormResponsesToHealthie/pushFormResponsesToHealthie.ts b/.../healthie/actions/dataExchange/pushFormResponsesToHealthie/pushFormResponsesToHealthie.ts
@@ -89,17 +89,19 @@ export const pushFormResponsesToHealthie: Action<
           },
         },
       })
+      const formAnswerGroupId =
+        res?.createFormAnswerGroup?.form_answer_group?.id
 
-      if (isEmpty(res?.createFormAnswerGroup?.form_answer_group?.id))
+      if (isEmpty(formAnswerGroupId))
         throw new HealthieFormResponseNotCreated(res)
 
       // separate call to lock the form if needed
-      if (lock) {
+      if (lock && formAnswerGroupId !== undefined) {
         await healthieSdk.client.mutation({
           lockFormAnswerGroup: {
             __args: {
               input: {
-                id: fields.healthieFormId,
+                id: formAnswerGroupId,
               },
             },
             form_answer_group: {
@@ -110,9 +112,7 @@ export const pushFormResponsesToHealthie: Action<
       }
       await onComplete({
         data_points: {
-          formAnswerGroupId: String(
-            res.createFormAnswerGroup?.form_answer_group?.id
-          ),
+          formAnswerGroupId: String(formAnswerGroupId),
         },
         events: getSubActivityLogs(mergedOmittedFormAnswers),
       })