Fix module renaming in compile-proto-file
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanrelf
reviewed
Mar 1, 2022
j6carey
requested changes
Mar 2, 2022
Changes: 1. remove `-XBangPatterns` in `Proto3.Suite.DotProto.Generate` 2. bump package version `0.4.3` -> `0.5.0`
j6carey
approved these changes
Mar 5, 2022
|
I added a unit test making sure that Testing code is overkill for what it's currently used for, but will make adding tests for other renaming functions in the future much easier. |
j6carey
requested changes
Mar 10, 2022
|
I got frustrated with trying to handle all of the edge cases (e.g. "A_") so I just rewrote |
fumieval
pushed a commit
to herp-inc/proto3-suite
that referenced
this pull request
Jun 13, 2022
* preserve character casing in module names * bump package version `0.4.3` -> `0.5.0`
fumieval
pushed a commit
to herp-inc/proto3-suite
that referenced
this pull request
Jun 13, 2022
* preserve character casing in module names * bump package version `0.4.3` -> `0.5.0`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way
compile-proto-filehandles generating valid Haskell module names from protobuf files, fixes issue #182.