fix: change to prevent capitalization of prefixed service method names #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the casing scheme applied to service methods in the code generator. Previously the code generator would take a protobuf service declaration such as
and emit the following record
The code generator no longer applies a casing-transformation on the first character of a service method name, this includes spans of capital letters prefixing the string. i.e. the code generator now emits
myServiceDubiousMethodName
andmyServicedubiousMethodName
. This change also includes documentation for the name resolution functions used in the code generator.Issue #170 documents other instances where malformed datatype declarations can be emitted by the code generator, this is an incremental step in improving how the edges cases listed in that issue are handled.