Add spire-1.7 #122
Merged
Add spire-1.7 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ixmatus
approved these changes
Jun 30, 2023
|
Could you backport (cherry pick) these two and add spire in separate commits please? They will be rebased onto main (not squashed) and it is really nice to have the comment match upstream. |
rkaippully
force-pushed
the
raghuk/spire-1.7
branch
from
268d4a4 to
f850512
Compare
|
Opened #123 for go-1.19 and changed this PR to only upgrade spire. |
Thank you! |
jsoo1
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires go-1.19. I got it working using a configuration similar to 1.17. We can switch to upstream 1.19 when we upgrade to newer versions of nixpkgs.