Remove super paranoid code to close file handles

avulanov · Aug 2, 2014 · 0374217 · 0374217
1 parent bda37bb
commit 0374217
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 30 deletions.
diff --git a/core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala b/core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
@@ -497,23 +497,9 @@ class ExternalAppendOnlyMap[K, V, C](
     private def cleanup() {
       batchIndex = batchOffsets.length  // Prevent reading any other batch
       val ds = deserializeStream
-      val fs = fileStream
       deserializeStream = null
       fileStream = null
-
-      if (ds != null) {
-        try {
-          ds.close()
-        } catch {
-          case e: IOException =>
-            // Make sure we at least close the file handle
-            if (fs != null) {
-              try { fs.close() } catch { case e2: IOException => }
-            }
-            throw e
-        }
-      }
-
+      ds.close()
       file.delete()
     }
   }

diff --git a/core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala b/core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala
@@ -618,23 +618,9 @@ private[spark] class ExternalSorter[K, V, C](
     def cleanup() {
       batchId = batchOffsets.length  // Prevent reading any other batch
       val ds = deserializeStream
-      val fs = fileStream
       deserializeStream = null
       fileStream = null
-
-      if (ds != null) {
-        try {
-          ds.close()
-        } catch {
-          case e: IOException =>
-            // Make sure we at least close the file handle
-            if (fs != null) {
-              try { fs.close() } catch { case e2: IOException => }
-            }
-            throw e
-        }
-      }
-
+      ds.close()
       // NOTE: We don't do file.delete() here because that is done in ExternalSorter.stop().
       // This should also be fixed in ExternalAppendOnlyMap.
     }