Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider libreadline/libedit only in interactive mode #1207

Merged
merged 3 commits into from
Dec 14, 2022

Commits on Dec 1, 2022

  1. Consider libreadline/libedit only in interactive mode

    There's not much point in running the entire terminal mode session
    on top of libreadline or libedit, unless it is clear the session
    is really running interactively on a terminal.
    
    Thus, only use the libreadline/libedit version if stdin points to
    a terminal. Otherwise, resort to the simple version without readline
    support. That ensures everything works well when running it within
    a pipeline.
    dl8dtl committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    30bffc3 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. Consider EditLine wrapper

    GNU libreadline does not seem to have any issues when running on a
    pipe as input, thus use it all the time.
    
    EditLine (NetBSD, MacOS) has issues with that, so only use it when
    running interactively on a terminal.
    dl8dtl committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    d746cef View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2022

  1. Use rl_readline_version rather than rl_library_version

    Besides of fixing a logico, this allows for a really straightforward
    decision. All EditLine versions so far use 0x0402 as their version
    number.
    dl8dtl committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    c51c5e7 View commit details
    Browse the repository at this point in the history