feat: infer result type correctly with TypeScript (no "npx tsc") #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this is 8.0.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you for looking at my previous PR #142 and my apologies that I was not aware "npx tsc" had an issue (as pointed out in #142 (comment) ). I am posting a new PR without "npx tsc".
This PR is exactly the same as my previous PR except:
typescript(Note, this is only for formality but has no actual impact becausetypescriptwas already included from another npm module implicitly. Runnpm why typescriptand see what it shows if you are interested.)I believe now
npm testshould pass as expected. I appreciate your effort. Thank you very much.