Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump @prisma/prisma-fmt-wasm to 3.8.0. #54

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Conversation

avocadowastaken
Copy link
Owner

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 11, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 825c573:

Sandbox Source
Vanilla Configuration

@avocadowastaken
Copy link
Owner Author

Hey @tomhoule! I can not migrate to 3.8.0 because of this change prisma/prisma-engines#2538, I've tried to pass params as it was done in https://github.com/prisma/language-tools/blob/b2902f66b819b0d2df4a446e2fda5212273278f0/packages/language-server/src/test/format.test.ts#L10-L20 but still no luck, could you please check 🙏

@tomhoule
Copy link

lib/plugin.js Outdated Show resolved Hide resolved
@avocadowastaken avocadowastaken changed the title chore: Bump @prisma/prisma-fmt-wasm to 3.8.0. feat: Bump @prisma/prisma-fmt-wasm to 3.8.0. Jan 11, 2022
@avocadowastaken avocadowastaken force-pushed the prisma-3.8.0 branch 2 times, most recently from c127393 to c8aaf96 Compare January 11, 2022 18:12
@avocadowastaken avocadowastaken merged commit 48586cb into main Jan 11, 2022
@avocadowastaken avocadowastaken deleted the prisma-3.8.0 branch January 11, 2022 18:53
@tomhoule
Copy link

wow, that's unexpected that it was so strict. We use the lsp-types crate so I guess they're strict about spec-compliant inputs. Kudos for figuring this out, sorry for the trouble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants