fix: undefined tags in field when editing #3315
Conversation
|
Code Climate has analyzed commit 851affa and detected 0 issues on this pull request. View more on Code Climate. |
coatezy
changed the title
|
Hey @coatezy thanks for the contribution! I noticed that some tests are failing. Could you please share the tags field code from your resource and more details about how to reproduce the issue? |
Hey, @Paul-Bob! Not problem. I'd be happy to try and understand why these are failing. The tags field is configured in the following way on the resource. |
|
I was able to reproduce the issue, I guess the tests are failing because tags cover several use cases and this change fixes this particular use case but maybe is breaking another use case, I'll also have a look |
coatezy
force-pushed
the
fix/undefined_tags_in_field_when_editing
branch
from
62be726
to
851affa
Compare
There was a problem hiding this comment.
I suggested some changes that might be effective.
When using suggestions https://docs.avohq.io/3.0/fields/tags.html#possible-values as an array of hashes the possibleSuggestion will respond to label but when used as array of values or not used at all it will NOT respond to label
| @@ -5,9 +5,9 @@ export function tagTemplate(tagData) { | |||
| // eslint-disable-next-line eqeqeq | |||
| (item) => item.value == tagData.value, | |||
| ) | |||
| const possibleLabel = possibleSuggestion | |||
| const possibleLabel = possibleSuggestion.label | |||
There was a problem hiding this comment.
| const possibleLabel = possibleSuggestion.label | |
| const possibleLabel = possibleSuggestion && 'label' in possibleSuggestion |
| ? possibleSuggestion.label | ||
| : tagData.value | ||
| : tagData.value; |
There was a problem hiding this comment.
| : tagData.value; | |
| : tagData.value |
Description
This PR fixes an undefined tag issue when editing existing tags on a resource.
Checklist:
Screenshots & recording
Before:
After:
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.