Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: sanitize key_value field content #2357

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

adrianthedev
Copy link
Collaborator

Description

Addresses GHSA-ghjv-mh6x-7q6h

Fixes a security issue where the output for the key_value field is not sanitized.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots

Manual review steps

  1. Follow the steps in the CVE to test.

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Jan 12, 2024

Code Climate has analyzed commit 7e54615 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev merged commit 51bb80b into main Jan 12, 2024
29 checks passed
@adrianthedev adrianthedev deleted the security/CVE-2024-22191 branch January 12, 2024 12:47
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Javascript Pull requests that update Javascript code Security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants