fix: sets ResourceHandler to not use filemapping, avoids win file locking #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cking issue on windows.
…cking issue on windows.
…/chipbite/structurizr-site-generatr into Fix_for_jetty_locking_on_windows
|
Ping @dirkgroot @jp7677 . |
chipbite
changed the title
|
Thanks for diving into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some digging (older solutions involved e g
useFileMappedBufferor forResourceHandlerit was settingsetMinMemoryMappedContentLengthto -1, now deprecated) I found that after this discussion,ResourceHandlergot a flag for using file mapping in jetty version 12.0.5 (jetty PR).So, its a oneliner. Took a few hours to dig it up, TBH.
Tested?
Yeah, on windows. Seems to work a charm. Sooo nice to not have it crash all the time.
However, I dont have access to a mac here. Guessing it will be fine, but nice to check... ;-)
This fixes #549.