Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added docker-compose to readme.md #280

Closed
wants to merge 6 commits into from

Conversation

bluecitylights
Copy link

Added example of docker-compose for easier handling the docker instance

Copy link
Collaborator

@dirkgroot dirkgroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this useful addition! I've added 2 remarks.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@dirkgroot dirkgroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I've added one last additional remark.

README.md Show resolved Hide resolved
@jp7677
Copy link
Contributor

jp7677 commented Oct 10, 2023

An alternative (my preference) for including this in the readme would be an entry here https://github.com/avisi-cloud/structurizr-site-generatr/discussions/categories/q-a

@jp7677
Copy link
Contributor

jp7677 commented Oct 20, 2023

As stated here #304 (comment) let’s also move this instructions to a separate markdown file in the docs folder. We can later refer to this from the q-a and also from the readme.

@dirkgroot
Copy link
Collaborator

I'm closing this PR for now. Feel free to reopen it if you want to continue working on this.

@dirkgroot dirkgroot closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants