-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added docker-compose to readme.md #280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this useful addition! I've added 2 remarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! I've added one last additional remark.
An alternative (my preference) for including this in the readme would be an entry here https://github.com/avisi-cloud/structurizr-site-generatr/discussions/categories/q-a |
As stated here #304 (comment) let’s also move this instructions to a separate markdown file in the docs folder. We can later refer to this from the q-a and also from the readme. |
I'm closing this PR for now. Feel free to reopen it if you want to continue working on this. |
Added example of docker-compose for easier handling the docker instance