Error: `No viewBox attribute found in SVG!` #279

nc-at-sp · 2023-07-27T12:33:18Z

I get this issue when attempting to serve my site locally. My model is relatively large and complex. This error does not always happen; if I exit and re-execute multiple times it will eventually work. It feels like a race condition or some other kind of threading issue to me.

OS: WSL (Ubuntu)
Java: 20.0.1 2023-04-18
structurizr-site-generatr version v1.1.4

structurizr-site-generatr serve -w my-file.dsl

java.lang.IllegalStateException: java.lang.IllegalStateException: No viewBox attribute found in SVG!
        at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:67)
        at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
        at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:484)
        at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:540)
        at java.base/java.util.concurrent.ForkJoinTask.reportException(ForkJoinTask.java:567)
        at java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:670)
        at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:159)
        at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:173)
        at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
        at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
        at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:765)
        at nl.avisi.structurizr.site.generatr.site.SiteGeneratorKt.generateHtmlFiles(SiteGenerator.kt:158)
        at nl.avisi.structurizr.site.generatr.site.SiteGeneratorKt.generateSite(SiteGenerator.kt:71)
        at nl.avisi.structurizr.site.generatr.ServeCommand.updateSite(ServeCommand.kt:82)
        at nl.avisi.structurizr.site.generatr.ServeCommand.execute(ServeCommand.kt:50)
        at kotlinx.cli.ArgParser.parse(ArgParser.kt:657)
        at kotlinx.cli.ArgParser.parse(ArgParser.kt:530)
        at nl.avisi.structurizr.site.generatr.AppKt.main(App.kt:13)
Caused by: java.lang.IllegalStateException: No viewBox attribute found in SVG!
        at nl.avisi.structurizr.site.generatr.site.model.DiagramViewModel$Companion.extractDiagramWidthInPixels(DiagramViewModel.kt:40)
        at nl.avisi.structurizr.site.generatr.site.model.DiagramViewModel$Companion.forView(DiagramViewModel.kt:28)
        at nl.avisi.structurizr.site.generatr.site.model.DiagramViewModel$Companion.forView(DiagramViewModel.kt:16)
        at nl.avisi.structurizr.site.generatr.site.model.SoftwareSystemComponentPageViewModel.<init>(SoftwareSystemComponentPageViewModel.kt:12)
        at nl.avisi.structurizr.site.generatr.site.SiteGeneratorKt$generateHtmlFiles$1$8$4.invoke(SiteGenerator.kt:133)
        at nl.avisi.structurizr.site.generatr.site.SiteGeneratorKt$generateHtmlFiles$1$8$4.invoke(SiteGenerator.kt:133)
        at nl.avisi.structurizr.site.generatr.site.SiteGeneratorKt$generateHtmlFiles$2.invoke(SiteGenerator.kt:158)
        at nl.avisi.structurizr.site.generatr.site.SiteGeneratorKt$generateHtmlFiles$2.invoke(SiteGenerator.kt:158)
        at nl.avisi.structurizr.site.generatr.site.SiteGeneratorKt.generateHtmlFiles$lambda$17(SiteGenerator.kt:158)
        at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
        at java.base/java.util.AbstractList$RandomAccessSpliterator.forEachRemaining(AbstractList.java:722)
        at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
        at java.base/java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290)
        at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:754)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
        at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
        at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
        at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
        at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)

The text was updated successfully, but these errors were encountered:

nc-at-sp · 2023-07-27T12:34:06Z

Also, I cannot share my model file as it contains proprietary data.

dirkgroot · 2023-08-11T08:44:04Z

Hi @nc-at-sp, thanks for reporting this issue.

I'm not sure what causes this. Could you try reproducing this issue and then see if there's SVG's in the build directory, that don't contain a viewBox attribute, or that have a viewBox attribute that does not match this regular expression: \d+ \d+ \d+ \d+ (that's what this tool is looking for).

nc-at-sp · 2023-08-11T11:45:35Z

Good morning. I went and checked every SVG file in the build directory. Each contains a viewBox attribute. Each looks like a variant of: viewBox="0 0 488 538" Each has 4 numbers (I'm assuming the regex below is just missing a 4th \d+ since it's not a viewTriangle) I also went through each page in the `build/master` and inspected each <svg> element, and all are as expected. If you could add a detail to the log saying which file is the problem, I can dive in and focus on that file. What's interesting is that if I hit "F5" to refresh, the entire page renders correctly **just for a second** and then the error appears. Also, this is not reliably repeatable. Exiting and running serve again will eventually give me a good session. But even if I don't change anything, and just exit and run serve again, the issue will eventually appear again. Hence my hypothesis about some kind of race condition. Thanks for your attention!

…

________________________________ From: Dirk Groot ***@***.***> Sent: Friday, August 11, 2023 4:44 AM To: avisi-cloud/structurizr-site-generatr ***@***.***> Cc: Nate Carpenter ***@***.***>; Mention ***@***.***> Subject: Re: [avisi-cloud/structurizr-site-generatr] Error: `No viewBox attribute found in SVG!` (Issue #279) Hi @nc-at-sp<https://github.com/nc-at-sp>, thanks for reporting this issue. I'm not sure what causes this. Could you try reproducing this issue and then see if there's SVG's in the build directory, that don't contain a viewBox attribute, or that have a viewBox attribute that does not match this regular expression: \d+ \d+ \d+ (that's what this tool is looking for). — Reply to this email directly, view it on GitHub<#279 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFZJIPP26BQXOJKKAOOXM23XUXWF7ANCNFSM6AAAAAA22AKYU4>. You are receiving this because you were mentioned.Message ID: ***@***.***>

dirkgroot · 2023-08-11T12:39:26Z

Thanks! My regex had an error. It should have been 4 \d+'s. Are there instances where one of the first two numbers in a viewBox attribute is a negative number?

nc-at-sp · 2023-08-11T12:41:54Z

At least in my instance they're always 0 0

dirkgroot · 2023-09-08T08:08:48Z

@nc-at-sp Okay, thanks. This looks like some kind of race condition indeed. I think I know where this occurs. Just for confirmation: Does your model contain diagrams that you have embedded in one or more documentation files using the ![](embed:diagram_key) syntax?

This should fix the error reported in #279.

dirkgroot · 2023-09-08T09:25:14Z

@nc-at-sp I've set up a PR with a possible fix for this issue (#308). Could you test if that change solves this issue?

You can download the binaries produced by this PR using this link.

nc-at-sp · 2023-09-08T11:58:24Z

@dirkgroot that seems to have done the trick; attempted 10 or so reloads and didn't see the issue once. Seems to be generally faster as well. Thanks!

This should fix the error reported in #279.

dirkgroot · 2023-09-11T11:40:13Z

Thanks for testing, @nc-at-sp! I've merged the PR, and will create a release somewhere this week. I'm closing this issue.

oneacik · 2023-09-25T11:43:02Z

Hello @dirkgroot,
when the docker image will be available with this fix?
Cheers.

dirkgroot added a commit that referenced this issue Sep 8, 2023

Keep a thread safe in-memory cache of generated diagrams with links

8837cd1

This should fix the error reported in #279.

dirkgroot mentioned this issue Sep 8, 2023

Keep a thread safe in-memory cache of generated diagrams with links #308

Merged

dirkgroot added a commit that referenced this issue Sep 11, 2023

Keep a thread safe in-memory cache of generated diagrams with links

19648b2

This should fix the error reported in #279.

dirkgroot closed this as completed Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error: `No viewBox attribute found in SVG!` #279

Error: `No viewBox attribute found in SVG!` #279

nc-at-sp commented Jul 27, 2023

nc-at-sp commented Jul 27, 2023

dirkgroot commented Aug 11, 2023 •

edited

Loading

nc-at-sp commented Aug 11, 2023 via email •

edited

Loading

dirkgroot commented Aug 11, 2023

nc-at-sp commented Aug 11, 2023

dirkgroot commented Sep 8, 2023 •

edited

Loading

dirkgroot commented Sep 8, 2023

nc-at-sp commented Sep 8, 2023 •

edited

Loading

dirkgroot commented Sep 11, 2023

oneacik commented Sep 25, 2023

Error: No viewBox attribute found in SVG! #279

Error: No viewBox attribute found in SVG! #279

Comments

nc-at-sp commented Jul 27, 2023

nc-at-sp commented Jul 27, 2023

dirkgroot commented Aug 11, 2023 • edited Loading

nc-at-sp commented Aug 11, 2023 via email • edited Loading

dirkgroot commented Aug 11, 2023

nc-at-sp commented Aug 11, 2023

dirkgroot commented Sep 8, 2023 • edited Loading

dirkgroot commented Sep 8, 2023

nc-at-sp commented Sep 8, 2023 • edited Loading

dirkgroot commented Sep 11, 2023

oneacik commented Sep 25, 2023

Error: `No viewBox attribute found in SVG!` #279

Error: `No viewBox attribute found in SVG!` #279

dirkgroot commented Aug 11, 2023 •

edited

Loading

nc-at-sp commented Aug 11, 2023 via email •

edited

Loading

dirkgroot commented Sep 8, 2023 •

edited

Loading

nc-at-sp commented Sep 8, 2023 •

edited

Loading