Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable writing stack trees to PR bodies #271

Merged
merged 4 commits into from
May 6, 2024

Conversation

oleg-codaio
Copy link
Contributor

@oleg-codaio oleg-codaio commented May 3, 2024

This PR adds a new configuration option, pullRequest.writeStack, that if enabled will add stack trees directly to GitHub pull requests.

For ease of navigation, these are added to the top as follows:

image

And when expanded, show the stack of requests from the latest PR down to the trunk branch:

image

Most PR stacks tend to be linear, but an alternate format is used if there are forks in the stack that make it look more like a tree:

image

This isn't the default format since I personally think the one above is cleaner to read, especially on phones that run out of horizontal real estate.

Copy link
Contributor

aviator-app bot commented May 3, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Contributor

aviator-app bot commented May 3, 2024

FlexReview Summary

Based on the code complexity and the author's expertise score, these are the suggested reviewers:

  • @draftcode (current review load: 4)

See the list of alternate reviewers in the detailed breakdown below.

Detailed Breakdown Author’s expertise score for the modified files:
  • cmd/av/pr_create.go (0.00)
  • cmd/av/stack_submit.go (0.00)
  • internal/actions/pr.go (0.00)
  • internal/actions/pr_test.go (0.00)
  • internal/actions/sync_branch.go (0.00)
  • internal/config/config.go (0.00)
  • internal/meta/branch.go (0.00)
  • internal/utils/stackutils/stackutils.go (0.00)
Files Reviewers
cmd/av/pr_create.go †,
internal/actions/sync_branch.go †,
internal/config/config.go
@draftcode (score: 1.00, current review load: 4),
@jainankit (score: 0.45, current review load: 0),
@doratzeng (score: 0.41, current review load: 0)

† Indicates that the file doesn't need an expert review. (?)

See full breakdown of the reviewers on the Aviator webapp.

@aviator-app aviator-app bot requested a review from draftcode May 3, 2024 01:09
@oleg-codaio oleg-codaio force-pushed the osv-stack-include branch from 73b6a24 to 3f15697 Compare May 3, 2024 02:16
internal/config/config.go Show resolved Hide resolved
internal/actions/pr.go Outdated Show resolved Hide resolved
@oleg-codaio oleg-codaio force-pushed the osv-stack-include branch from 4db7fd2 to 429a31f Compare May 6, 2024 17:22
@aviator-app aviator-app bot merged commit 17cc574 into aviator-co:master May 6, 2024
4 checks passed
@draftcode
Copy link
Contributor

I'll cut a new release for av-cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants