Pincode validation, test card & cors fixes. #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkrawat1
reviewed
Jul 23, 2018
| <ng-template [ngSwitchCase]="'Check'"> | ||
| <app-cash-on-delivery (payOnDelivery)="makePayment()"></app-cash-on-delivery> | ||
| <ng-template [ngSwitchCase]="'COD'"> | ||
| <app-cash-on-delivery (payOnDelivery)="makePaymentCod()"></app-cash-on-delivery> | ||
| </ng-template> | ||
| <ng-template [ngSwitchCase]="'Payubiz'"> |
There was a problem hiding this comment.
Why string comparison. Also if payment mode name is changed, then what!! redeployment ???
pkrawat1
reviewed
Jul 23, 2018
| import { Address } from '../../../core/models/address'; | ||
| import { environment } from '../../../../environments/environment'; | ||
| import { ToastrService } from '../../../../../node_modules/ngx-toastr'; |
There was a problem hiding this comment.
Why absolute path for ngx-toastr
pkrawat1
reviewed
Jul 23, 2018
|
|
||
| paymentModes: PaymentMode[]; | ||
| selectedMode: PaymentMode = new PaymentMode; | ||
| isAuthenticated: boolean; | ||
| showOrderSuccess = false; | ||
| free_shipping_order_amount = environment.config.free_shipping_order_amount; |
pkrawat1
reviewed
Jul 23, 2018
| @@ -5,7 +5,7 @@ import { Store } from '@ngrx/store'; | |||
| import { Observable, Subscription } from 'rxjs'; | |||
| import { Component, OnInit, OnDestroy } from '@angular/core'; | |||
| import { environment } from '../../../environments/environment'; | |||
| import { CheckoutService } from '../../core/services/checkout.service'; | |||
| import { Router } from '../../../../node_modules/@angular/router'; | |||
There was a problem hiding this comment.
check the import path before auto applying
pkrawat1
reviewed
Jul 23, 2018
| @@ -6,7 +6,7 @@ export class PaymentService { | |||
| setCODAsSelectedMode(modes) { | |||
| let selectedMode; | |||
| modes.forEach((mode) => { | |||
| if (mode.name === 'Check') { | |||
| if (mode.name === 'Payubiz') { | |||
pkrawat1
pushed a commit
that referenced
this pull request
Jul 30, 2018
Why? Features Added random transaction id for every payubiz transaction. Added test card when user clicks on payubiz payment method for testing payment process. Added pincode check for COD orders. Fixes Eliminated Cors: Instead of Ajax the form-data post request has been made via backend api. This change addresses the need by: Random transaction ID instead of Order-Id. Test card will helps user to test payubiz payment Process. Now Orders with available pincodes are eligible for free shipping with specified free shipping value. [delivers #159134594, #159209334]
pkrawat1
pushed a commit
that referenced
this pull request
Jul 30, 2018
Why? Features Added random transaction id for every payubiz transaction. Added test card when user clicks on payubiz payment method for testing payment process. Added pincode check for COD orders. Fixes Eliminated Cors: Instead of Ajax the form-data post request has been made via backend api. This change addresses the need by: Random transaction ID instead of Order-Id. Test card will helps user to test payubiz payment Process. Now Orders with available pincodes are eligible for free shipping with specified free shipping value. [delivers #159134594, #159209334]
pkrawat1
pushed a commit
that referenced
this pull request
Sep 20, 2023
Why? Features Added random transaction id for every payubiz transaction. Added test card when user clicks on payubiz payment method for testing payment process. Added pincode check for COD orders. Fixes Eliminated Cors: Instead of Ajax the form-data post request has been made via backend api. This change addresses the need by: Random transaction ID instead of Order-Id. Test card will helps user to test payubiz payment Process. Now Orders with available pincodes are eligible for free shipping with specified free shipping value. [delivers #159134594, #159209334]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Features
Fixes
This change addresses the need by:
[delivers #159134594, #159209334]
Story Test Card.
Story Pincode check.