Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header mobile menu #149

Merged
merged 3 commits into from
Jun 1, 2018
Merged

Header mobile menu #149

merged 3 commits into from
Jun 1, 2018

Conversation

jaypal412
Copy link
Contributor

@jaypal412 jaypal412 commented May 31, 2018

Motivation and Context

We have to create the mobile top menu. When the mobile to open the cross icon will change his state.
Firstly we have to fetch the categories in the window in rows. When we click on any row sub-categories will load in the window in a row format and so on.

Describe your changes

To achiive achive our motivition I have performed belowed task step wise.

  • Add the ngx bootstarp module.
  • Run the bootstrap module without the backdrop.
  • Create the new componet for the categories and include this component in the model-body,
  • Manupliate the data of the categories and align all categories in row with the help of the css..
  • Add animation with the help of angular animations.
  • Change the state of the menu icon on click.

Any further comments?

  • Form this work I haved worked on the animation a lot.

Checklist

  • I have read CONTRIBUTING.md.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code does not generate any (new) credo and compile-time warnings.
  • I have updated the documentation wherever necessary.
  • I have added tests to cover my changes.

Dear Gatekeeper,

Please make sure that the commits that will be merged or rebased into the base
branch are formatted according to our standards.

The only additional requirement is that the the PR number must appear in the
commit title in brackets: (#XXX)

@pkrawat1 pkrawat1 merged commit c29171d into develop Jun 1, 2018
@ashish173 ashish173 deleted the header-mobile-menu branch June 1, 2018 11:52
@@ -86,7 +87,7 @@
height: 48px;
background: #0bc6a0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really colour code like this?

@@ -18,7 +19,7 @@
color: #535766;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code?

@@ -29,7 +30,7 @@
font-size: 17px;
color: #596062;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

color code again? 👎

pkrawat1 pushed a commit that referenced this pull request Jun 13, 2018
* Work on header menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants