Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page slider UI fixes and styling for Sliders #106

Merged
merged 2 commits into from
Apr 27, 2018

Conversation

y2kanthale
Copy link
Member

No description provided.

}
/deep/ .slider-section {
position: relative;
/deep/ .slider-control {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add /deep/ here if parent /deep/ .scrollbar-hidden already has it

@gopalshimpi gopalshimpi self-requested a review April 27, 2018 06:58
Copy link
Member

@gopalshimpi gopalshimpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pkrawat1 pkrawat1 merged commit 16d78c3 into develop Apr 27, 2018
@pkrawat1 pkrawat1 deleted the landing-page-ui branch April 27, 2018 07:00
pkrawat1 pushed a commit that referenced this pull request Jun 13, 2018
* Landing page slider UI fixes and styling

* Quick changes for deep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants