Added Shop by Category & brand #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added banner componant 2. Added product list componant 3. Chnages in routes 4. Added carousal library
1. Added Scrollable to componant 2. Added watch&learn componant 3. Added configurable data file. 4. Modified product list & favorite item componant.
implemented update password. Litle housekeeping with notifications
1. Added componants for dropdown 2. Api call for taxonami 3. Mapping the data to componant.
pkrawat1
requested changes
Apr 25, 2018
| <div class="btn-group" dropdown [autoClose]="false" container="body"> | ||
| <button id="button-nested" dropdownToggle type="button" class="btn bg-white dropdown-toggle" aria-controls="dropdown-nested"> | ||
| Shop By | ||
| <span *ngIf="taxonomies.length!==0">{{taxonomies[0].name}}</span> |
There was a problem hiding this comment.
What if api only sends the array of size 1 only. Then will it not break at this point.
Can you please add an *ngIf="taxonomies[0]; let brands_taxonomy"
| styleUrls: ['./categories-details.component.scss'] | ||
| }) | ||
| export class CategoriesDetailsComponent implements OnInit, OnChanges { | ||
| @Input() taxons; |
| styleUrls: ['./categories-list.component.scss'] | ||
| }) | ||
| export class CategoriesListComponent implements OnInit { | ||
| @Input () taxons; |
| <button id="button-nested" dropdownToggle categories="button" class="btn bg-white dropdown-toggle" aria-controls="dropdown-nested" | ||
| data-hover="dropdown"> | ||
| Shop By | ||
| <span *ngIf="taxonomies.length!==0">{{taxonomies[0].name}}</span> |
There was a problem hiding this comment.
put taxonomies[0] in a template variable
| } | ||
|
|
||
| ngOnChanges() { | ||
| console.log('categeory', this.taxonomies) |
There was a problem hiding this comment.
remove all console.logs if Pr is ready
| </nav> | ||
| <nav class="navbar navbar-expand-lg"> |
There was a problem hiding this comment.
How about we move this to another component ?
There was a problem hiding this comment.
We will discuss about it.
pkrawat1
pushed a commit
that referenced
this pull request
Jun 13, 2018
* Added Landing page 1. Added banner componant 2. Added product list componant 3. Chnages in routes 4. Added carousal library * Added Modified landing page 1. Added Scrollable to componant 2. Added watch&learn componant 3. Added configurable data file. 4. Modified product list & favorite item componant. * added custom themes * Added Forgot password component. * Modified forgot password * added update password componant * Added Update password component * Modified according to http client. implemented update password. Litle housekeeping with notifications * Updated data.ts * Adde control to header for pets & brand as per mega menu * Added Header Drop down for Shop by categeory 1. Added componants for dropdown 2. Api call for taxonami 3. Mapping the data to componant. * Requested chnages * Modifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.