Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add adrianosela/multikey (under security repos) #4855

Merged
merged 1 commit into from
May 19, 2024

Conversation

adrianosela
Copy link
Contributor

@adrianosela adrianosela commented Apr 19, 2023

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Please provide package links to:

✔ ~/go/src/github.com/adrianosela/multikey [master|✔]
09:13 $ go test -cover ./...
ok  	github.com/adrianosela/multikey	1.536s	coverage: 90.9% of statements
ok  	github.com/adrianosela/multikey/galois	0.157s	coverage: 100.0% of statements
ok  	github.com/adrianosela/multikey/keys	0.544s	coverage: 100.0% of statements
ok  	github.com/adrianosela/multikey/shamir	0.334s	coverage: 100.0% of statements

Note: that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below that apply before you submit PR.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.
  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • I have read the Contribution Guidelines, Maintainers Note and Quality Standards.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged
  • The authors of the project do not commit directly to the repo, but rather use pull requests that run the continuous-integration process. -- yes, going forward, protected master branch

Thanks for your PR, you're awesome! 👍

@adrianosela
Copy link
Contributor Author

Hi @avelino -- thank you for running this repo. This is ready for eyes, excited to get my second library in here.

@adrianosela
Copy link
Contributor Author

Hey @phanirithvij - wondering if we can get this in?

@phanirithvij phanirithvij merged commit 667d0c5 into avelino:main May 19, 2024
@phanirithvij
Copy link
Collaborator

Can you add tests and get good code coverage please. Also it has been a year since the last commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants