Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Modify annotations and schemas #76

Merged
merged 7 commits into from
Dec 6, 2024
Merged

feat!: Modify annotations and schemas #76

merged 7 commits into from
Dec 6, 2024

Conversation

jarbesfeld
Copy link
Collaborator

@jarbesfeld jarbesfeld commented Dec 5, 2024 •
edited
Loading

Adds several new changes

  • Updates mapped variant structure to include an extension that lists the VA digest for it's corresponding pre-mapped variant
  • Adds check to ensure MAVE sequence has proper length for compatibility with BLAT
  • Updates schema to check for target type snake_case format

@jarbesfeld jarbesfeld added the enhancement New feature or request label Dec 5, 2024
@jarbesfeld jarbesfeld self-assigned this Dec 5, 2024
jsstevenson
jsstevenson approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good generally, 1 small comment

src/dcd_mapping/annotate.py Outdated Show resolved Hide resolved
@jarbesfeld jarbesfeld merged commit ab81645 into main Dec 6, 2024
8 checks passed
@jarbesfeld jarbesfeld deleted the add_va_extension branch December 6, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsstevenson jsstevenson jsstevenson approved these changes

Assignees

@jarbesfeld jarbesfeld

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarbesfeld @jsstevenson