Update notebooks, alignment, and mapping code #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jarbesfeld
commented
Oct 1, 2024
•
jarbesfeld
commented
- Update analysis notebooks to reference the summary statistics in the updated preprint
- Update alignment code to ensure correct BLAT parameters are being used and that the correct strand orientation is selected for protein coding DNA target sequences
- Update vrs_map to skip protein mapping when only genomic variants should be mapped
jsstevenson
approved these changes
Oct 1, 2024
jsstevenson
requested changes
Oct 1, 2024
There was a problem hiding this comment.
The tests still assume that the extra objects get created -- I think behavior is correct so we should update the expected values so that they pass in CI. Can work through that with you if it gives you trouble.
jsstevenson
requested changes
Oct 7, 2024
|
|
||
| return None | ||
|
|
||
|
|
||
| def extract_potential_gene_symbol(word: str) -> str: | ||
| """Remove paranetheses from a potential gene symbol |
There was a problem hiding this comment.
blank line between the first sentence in the docstring and the first :param: line
jsstevenson
approved these changes
Oct 9, 2024
|
looks like tests are failing now fyi |
jsstevenson
reviewed
Oct 9, 2024
jsstevenson
requested changes
Oct 9, 2024
jsstevenson
requested changes
Oct 9, 2024
jsstevenson
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.