Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the original converter of LLVM IR into BIR from llvmir2hll #509

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Remove the original converter of LLVM IR into BIR from llvmir2hll #509

merged 2 commits into from
Feb 28, 2019

Commits on Feb 28, 2019

  1. llvmir2hll: Remove the original converter of LLVM IR into BIR (#508). 

    Now that retdec-llvmir2hll is using the new converter of LLVM IR into BIR, we
can remove the original (old) one.

Reasons:
* Nobody will probably ever use it.
* We will not have to maintain two converters.
* Fewer `.cpp` files to compile.

Notes:
* We have to preserve labels_handler.cpp from the original converter as this
  module is also used by the new converter.
* The retdec-decompiler.py script had to be also updated (to prevent users from
  specifying 'orig' via --backend-llvmir2bir-converter.
    @s3rvac
    s3rvac committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    885633a View commit details
    Browse the repository at this point in the history

  2. llvmir2hll: Remove the possibility of having multiple LLVMIR-to-BIR c… 

    …onverters.

We do not believe that we will have another converter in the future. Also,
having multiple converters would be unnecessarily hard to maintain (we would
have to write regression tests for both of them).
    @s3rvac
    s3rvac committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    9759427 View commit details
    Browse the repository at this point in the history