adds FreeBSD OS, and potentially other BSD OSes

[gwquk]

Successfully compiles on FreeBSD 12 (which is the latest release). Other BSDs may also work with these changes. Clang (LLVM) 7 had a problem (error) with the line in bold from ./src/utils/memory.cpp
bool limitSystemMemoryOnPOSIX(std::size_t limit) {
struct rlimit rl = {
.rlim_cur = limit, // Soft limit.
I had to add this to the ./CMakeLists.txt, so Clang created a 'warning' during compilation not an 'error'
# Clang does Wc++11-narrowing, must be off for memory.ccp line 35
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-error=c++11-narrowing")

I have fixed my 'push' identity to gwquk

Thanks for making this Open Source!
Greg

[s3rvac]

Thank you for adding support for BSD! 👍 We would definitely like to merge the PR. However, I have included several comments and suggestions that should be resolved first.

[s3rvac]

Hello @gwquk. Have you closed this PR by accident or have you stumbled upon something that has rendered the PR unusable?

[gwquk]

Yes, trying to solve this problem...

git push origin master

Username for 'https://github.com':
Password for 'https://[email protected]':
remote: Permission to avast-tl/retdec.git denied to gwquk.
fatal: unable to access 'https://github.com/avast-tl/retdec.git/': The requested URL returned error: 403

[gwquk]

I have made all the suggested changes... including the README.md (which I edited manually) just can't get git to push.

[s3rvac]

It seems that you are trying to push to https://github.com/avast-tl/retdec.git You will have to push to your fork instead: https://github.com/gwquk/retdec.git

[gwquk]

Have i managed to fix the issue?

[s3rvac]

I do not see the changes here. Have you pushed them? Anyway, let's open the PR.

[s3rvac]

Now that the PR is opened, I can see the changes.

[s3rvac]

Thank you for the changes and README improvements 👍. There are a few more things that need to be resolved before we can merge this.

[s3rvac]

All of our builds have succeeded after the latest fixes 👏. Would you like to change/add anything else or can I merge the PR?

[gwquk]

Yes please do. 👍 There are a couple of compiler warnings that need further investigating but the retdec-decompiler program seems to run fine with initial testing.

[s3rvac]

Great, thank you! 👍

[s3rvac]

As for the Clang compilation warnings, I have fixed several of them in 4c37f60 and d9077c4 (on Linux), but feel free to either report the missed ones to us by opening an issue or submitting a PR which fixes the warnings Clang reports on your system.

[gwquk]

OK, Thanks On Thursday, 31 January 2019, 6:42:34 am GMT, Petr Zemek <[email protected]> wrote: As for the Clang compilation warnings, I have fixed several of them in 4c37f60 and d9077c4 (on Linux), but feel free to either report the missed ones to us by opening an issue or submitting a PR which fixes the warnings Clang reports on your system. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[lwhsu]

Thanks for working on FreeBSD support! Is there any plan to have a hosted CI with FreeBSD integrated? Currently there is https://cirrus-ci.com/ supports FreeBSD.

Also, I would like to help on getting this to FreeBSD ports tree to have a pre-built package available, @gwquk , are you interested in doing this?

[s3rvac]

@lwhsu Good idea. I have created an issue for connecting RetDec to a CI service supporting FreeBSD: #493. As we have no experience with FreeBSD, we encourage the community to help.