Die as intended on bin2pat error #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3rvac
added a commit
that referenced
this pull request
Jan 28, 2019
Required after the changes in #474.
s3rvac
added a commit
that referenced
this pull request
Jan 28, 2019
After #474, printErrorAndDie() no longer returns anything, so we can change the return value from `int` to `void` and reflect this change in other parts of the code. Also, add return statements after terminating functions to improve the code readability.
s3rvac
added a commit
that referenced
this pull request
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #473,
bin2patdoes not die correctly when an error is encountered, which affects the running of other scripts.