-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a recursive function call with a iterative function #450
Conversation
scripts/retdec-config.py
Outdated
|
||
if platform == "darwin": | ||
# mac os x doesn't support the v flag | ||
LOG_TIME = ['/usr/bin/time'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this fixes the /usr/bin/time: invalid option -- 'v'
error on macOS, it does not represent a full solution to #383 as our scripts assume that /usr/bin/time
is run with -v
. Apart from other information, the -v
parameter makes /usr/bin/time
produce memory usage of the tracked program, which we then parse in our scripts. Without -v
, the used memory will always be 0, which I believe is incorrect and thus this fix cannot be merged. What is your take on this @PeterMatula ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I looked in the docs by Mac OS X and I found the parameter -l
.
I will change it. But this flag not show all information that shown on ubuntu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I found a package by brew
the gnu-time
, this will give the same output.
Which would be better to integrate?
capstone2llvmir/mips: add semantics for more instructions, #393.
cmake: Fix a typo in a comment.
@PeterMatula Can you please take a look at this PR? It has been opened for more than a month now. |
and