Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a recursive function call with a iterative function #450

Merged
merged 17 commits into from
Mar 2, 2019
Merged

Remove a recursive function call with a iterative function #450

merged 17 commits into from
Mar 2, 2019

Conversation

Cyperghost
Copy link
Contributor

  • The X87 analysis function breaks by large executable files, with a stack overflow

and


if platform == "darwin":
# mac os x doesn't support the v flag
LOG_TIME = ['/usr/bin/time']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this fixes the /usr/bin/time: invalid option -- 'v' error on macOS, it does not represent a full solution to #383 as our scripts assume that /usr/bin/time is run with -v. Apart from other information, the -v parameter makes /usr/bin/time produce memory usage of the tracked program, which we then parse in our scripts. Without -v, the used memory will always be 0, which I believe is incorrect and thus this fix cannot be merged. What is your take on this @PeterMatula ?

Copy link
Contributor Author

@Cyperghost Cyperghost Jan 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I looked in the docs by Mac OS X and I found the parameter -l.
I will change it. But this flag not show all information that shown on ubuntu.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I found a package by brew the gnu-time, this will give the same output.
Which would be better to integrate?

@Cyperghost Cyperghost changed the title Remove the recursive function call with a iterative function Remove a recursive function call with a iterative function Jan 7, 2019
@s3rvac
Copy link
Member

s3rvac commented Feb 5, 2019

@PeterMatula Can you please take a look at this PR? It has been opened for more than a month now.

@PeterMatula PeterMatula merged commit 9d2bf66 into avast:master Mar 2, 2019
PeterMatula added a commit that referenced this pull request Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants