Fix #384 - bin2llvmir: Be more strict when merging values #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Massive test fallout 😞 |
|
I will look into this. I think there might be something there - the change is not entirely bad and might make sense. But it looks like many RetDec parts are relying on the original behavior - maybe they should not and it should be solved in a different manner. |
|
@PeterMatula Were you able to look into this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues mentioned in #384. I merely removed the check that made load result and the load origin considered equivalent, this is definitely wrong. Maybe some other checks here are also wrong, I can't really tell.