Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor function argument and return value analysis #155

Closed
PeterMatula opened this issue Feb 6, 2018 · 4 comments
Closed

Refactor function argument and return value analysis #155

PeterMatula opened this issue Feb 6, 2018 · 4 comments

Comments

@PeterMatula
Copy link
Collaborator

The analysis that recognizes function arguments and function return values needs refactoring to make it better. This issue lists all the problems, that should be solved by the new analysis.

@PeterMatula
Copy link
Collaborator Author

Too many arguments of function foo in test.zip:

// Address range: 0x80484a0 - 0x80484b2
int32_t foo(int32_t a1, int32_t a2, int32_t a3) {
    // entry
    return 5;
}

@PeterMatula
Copy link
Collaborator Author

Similar problems in for-test.zip.

@PeterMatula PeterMatula added this to the RetDec v4 milestone Sep 16, 2019
@PeterMatula
Copy link
Collaborator Author

The new function argument/return analysis was already deployed. So maybe this is fixed. @xkubov try to look at it. If it is ok, create a regression tests and close it. If it is not, we can look into it.

@PeterMatula PeterMatula modified the milestones: RetDec v4, RetDec v4+ Apr 8, 2020
xkubov pushed a commit to avast/retdec-regression-tests that referenced this issue Aug 1, 2020
This test was created for/with input from issue
avast/retdec#155
@xkubov xkubov closed this as completed in 9a13ab3 Aug 2, 2020
@xkubov
Copy link
Contributor

xkubov commented Aug 2, 2020

All problems mentioned in this thread are solved by 9a13ab3. I am closing this issue.

Included files were put into RetDec's Regression tests set. avast/retdec-regression-tests@1082936

xkubov pushed a commit that referenced this issue Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants