Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for situation where junk data lies before rich header #91

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Add test for situation where junk data lies before rich header #91

merged 2 commits into from
Jul 9, 2021

Conversation

HoundThe
Copy link
Member

Regression test for avast/retdec#973

@PeterMatula PeterMatula self-requested a review July 9, 2021 16:08
@PeterMatula
Copy link
Collaborator

Looks good. But in the future, please include PR or issue number in the test directory name if possible (i.e. PR or issue exists). I.e. issue-973-rich-header-junk instead of just rich-header-junk.

I know most of the directories in tools/fileinfo/bugs don't do this, but it is because these were migrated there during open sourcing of RetDec and they didn't have a corresponding issue in the public repo - we used private repo before and there was no point in using the old issue numbers in such cases.

@HoundThe
Copy link
Member Author

HoundThe commented Jul 9, 2021

Sure! That sounds like a good idea, I'll change it for this PR quickly

@PeterMatula PeterMatula merged commit 0103738 into avast:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterMatula PeterMatula PeterMatula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HoundThe @PeterMatula