Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API for nested settings reading #290

Merged
merged 2 commits into from
Apr 8, 2021
Merged

feat: API for nested settings reading #290

merged 2 commits into from
Apr 8, 2021

Conversation

augi
Copy link
Member

@augi augi commented Apr 8, 2021

This PR solves #289 by introducing the nested method, to get previously created nested settings.

This PR also changes the original createNested method to protected and renames it (because it is not intended to be called by users), but also introduces a new method with the same signature, to keep backward compatibility.

The issue with the original createNested was that it created a new nested settings but it didn't register it (so it wasn't possible to read it later).

@augi augi merged commit 03e12df into main Apr 8, 2021
@augi augi deleted the BetterNestedForKotlin branch April 8, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant