Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows Containers #105

Merged
merged 2 commits into from
Oct 10, 2017
Merged

Support Windows Containers #105

merged 2 commits into from
Oct 10, 2017

Conversation

augi
Copy link
Member

@augi augi commented Oct 10, 2017

When exposing a port on Windows Container, the port is not available on the localhost but on the gateway of Docker NAT network. It would be hard to read that value so we use direct access to the container that also works.

The issue is described here

@augi augi merged commit 1389b52 into master Oct 10, 2017
@alenkacz
Copy link
Contributor

no code review? shame on you! :-)

@augi
Copy link
Member Author

augi commented Oct 11, 2017

Maybe it's a product of pair programming, who knows ;-)

@augi augi deleted the SupportWindowsContainers branch March 22, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants