Skip to content

Commit

Permalink
Makefile: do not export mandir/htmldir/infodir
Browse files Browse the repository at this point in the history
These are defined in the main Makefile to be funny values that are
optionally relative to an unspecified location that is determined at
runtime.  They are only suitable for hardcoding in the binary via
the -DGIT_{MAN,HTML,INFO}_PATH=<value> C preprocessor options, and
are not real paths, contrary to what any sane person, and more
importantly, the Makefile in the documentation directory, would
expect.

A longer term fix is to introduce runtime_{man,html,info}dir variables
to hold these funny values, and make {man,html,info}dir variables
to have real paths whose default values begin with $(prefix), but
as a first step, stop exporting them from the top-level Makefile

Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
gitster committed Feb 12, 2013
1 parent d8cf908 commit c09d62f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ lib = lib
# DESTDIR=
pathsep = :

export prefix bindir sharedir mandir htmldir sysconfdir gitwebdir localedir
export prefix bindir sharedir sysconfdir gitwebdir localedir

CC = cc
AR = ar
Expand Down

0 comments on commit c09d62f

Please sign in to comment.