Print the planned and actual assertion count when incorrect. #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestalmage
force-pushed
the
print-plan-expectation
branch
from
c09cc49 to
6f71975
Compare
| @@ -11,6 +11,7 @@ var inspect = require('util').inspect; | |||
| var assert = require('./assert'); | |||
| var enhanceAssert = require('./enhance-assert'); | |||
| var globals = require('./globals'); | |||
| var plur = require('plur'); | |||
There was a problem hiding this comment.
Should be above relative require calls.
Wish we had a ESLint rule for this. (sindresorhus/project-ideas#62)
jamestalmage
force-pushed
the
print-plan-expectation
branch
from
6f71975 to
07febb2
Compare
|
|
jamestalmage
added a commit
that referenced
this pull request
Mar 22, 2016
Print the planned and actual assertion count when incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102
The assertion error already had
expectedandactualproperties, but only the tap reporter displays those. Instead of modifying existing reporters to handle the special case of planned assertions, I took the easy way out and just dynamically generated the error message.