Added recipe for writing test with code depending on a window object #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,73 @@ | |||
| # Setting up AVA for browser testing. | |||
|
We had some users ask for this one previously. I like it, thank you for your work @bachstatter! If you could address fixes/suggestions, it'd be good to merge ;) |
|
|
||
| t.true(onUserBlur.calledOnce) | ||
| }) | ||
| ``` |
|
Thanks for all the feedback. English is my second language. Will update as soon as possible |
| # Setting up AVA for browser testing | ||
|
|
||
| AVA does not support running tests in browsers yet. | ||
| Some libraries require ```window``` object is defined. |
There was a problem hiding this comment.
This line could be better:
Some libraries require browser specific globals (
window,document,navigator, etc).
Also, You just need a single tick around window (not triple).
|
LGTM. Just some minor nits. |
| @@ -0,0 +1,69 @@ | |||
| # Setting up AVA for browser testing | |||
|
|
|||
| AVA does not support running tests in browsers yet. | |||
There was a problem hiding this comment.
Link the word yet to the issue tracking browser support?
|
Thank you @bachstatter. Good stuff :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was debating if it should be called react-testing or browser-testing and decided to call it browser-testing since if solves a problem for all libraries that expect a global window object.
I'm happy to add changes based on feedback