improve test coverage for calling classes without the new keyword
#557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,7 +6,7 @@ var BAIL_ERROR = new Error(); | |||
| module.exports = Concurrent; | |||
|
|
|||
| function Concurrent(tests, bail) { | |||
| if (!this instanceof Concurrent) { | |||
| if (!(this instanceof Concurrent)) { | |||
There was a problem hiding this comment.
I'm surprised the linter didn't catch this. Would have thought ESLint would have rule for this.
sindresorhus
changed the title
new keyword
|
Good catch! Thank you. Keep'em coming ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into #161 I noticed that several tests for the constructions of objects were not checking the message from the expected exception, which caused a couple of bugs to be missed (and some lines not to be covered).
I improved the tests and corrected the bugs, and also added similar tests to all constructable classes that were making the "invoke with new" check. I also standardized the test message and the general structure, since different tests seemed to be handling it with different naming conventions for the auxiliary variables.