contributing.md - seek early feedback #356
Conversation
| @@ -33,6 +33,7 @@ We have a [chat](https://gitter.im/sindresorhus/ava). Jump in there and lurk, ta | |||
| ### Submitting a pull request | |||
|
|
|||
| - Non-trivial changes are often best discussed in an issue first, to prevent you from doing unnecessary work. | |||
| - For ambitious tasks, you should try to get your work in front of the community for feedback as soon as possible. Open a PR as soon as you have done the minimum needed to demonstrate your idea. At this early stage, don't worry about making things perfect, or 100% complete. Add a [WIP] prefix to the title, and describe what you still need to do. This lets reviewers know not to nit-pick small details or point out improvements you already know you need make. | |||
There was a problem hiding this comment.
you need make => you need to make
sindresorhus
changed the title
jamestalmage
force-pushed
the
seek-early-feedback
branch
from
84d7fe4 to
94c0f9b
Compare
|
@sindresorhus - updated. |
contributing.md - seek early feedback
|
Excellent. |
|
For clarification, should an issue be raised for discussion first, then open a PR? |
Oh, absolutely. Does the line above not make that clear? Should we amend this:
To
|
|
Should have waited for a bit more consensus on this PR! 😉 |
|
Ah! I see it now, it's the first point. All good then.. Though the dot points are quite wordy, dot points should be short and sharp eg:
|
Ah, yes, but it looked pretty clear cut. Will give it some more time in the future. |
|
I thought so to, I was just pointing out the irony that we rushed the PR that said "seek feedback ... find consensus". |
|
Lol, that's true :p |
As requested: #346 (comment)