Hide test internals. Fixes #252. #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return self[name]; | ||
| } | ||
| }); | ||
| }, this); |
|
Generally looks good to me. |
| @@ -230,3 +199,60 @@ Test.prototype.exit = function () { | |||
| }); | |||
| } | |||
| }; | |||
|
|
|||
| Test.prototype.publicApi = function () { | |||
There was a problem hiding this comment.
Maybe make this _publicApi? I don't see why anyone would need it.
jamestalmage
force-pushed
the
hide-test-internals
branch
3 times, most recently
from
e673e40
to
c5f2ac2
Compare
jamestalmage
force-pushed
the
hide-test-internals
branch
from
c5f2ac2
to
c78c46f
Compare
jamestalmage
added a commit
that referenced
this pull request
Nov 30, 2015
Hide test internals. Fixes #252.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered the delegates module, but that still requires exposing the Test
object itself as a member of
api, and does not bindthisfor the exposedfunctions.
Fixes #252.