Add ES2015 support to CLI #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea why execFile failed in travis |
| t.plan(3); | ||
|
|
||
| execFile('./cli.js', ['test/es2015.js'], { | ||
| cwd: __dirname |
There was a problem hiding this comment.
cwd: path.resolve(__dirname, '..')
|
Awesome! Thanks for working on this :) Would you mind adding something about it to the readme too? |
|
Why did you remove the test? Can you fix the merge conflict? |
| var updateNotifier = require('update-notifier'); | ||
|
|
||
| try { | ||
| require(resolveFrom('.', 'babel/register')); | ||
| } catch (e) { |
|
I will fix |
|
@sindresorhus I fixed conflicts |
|
Can you add back the test? We need a test to make sure it's working ok. |
| var updateNotifier = require('update-notifier'); | ||
|
|
||
| try { | ||
| require(resolveFrom('.', 'babel/register')); |
There was a problem hiding this comment.
This should also be babel-core.
There was a problem hiding this comment.
Actually, should probably do both, in case users use plain babel.
require(resolveFrom('.', 'babel-core/register') || resolveFrom('.', 'babel/register'));
Closed
|
Looks good. Thank you @andrepolischuk :) |
|
Thank you for review and comments |
|
🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20