Event data improvements #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| duration: test.duration, | ||
| title: test.title, | ||
| error: test.assertError, | ||
| err: test.assertError, |
There was a problem hiding this comment.
I would prefer error for consistency.
There was a problem hiding this comment.
Haha, I changed it to err for consistency too :D
There was a problem hiding this comment.
I feel it's different. This is more like passing around data than variables. Think of it as a table of data and the keys are the headers. At least how it's like in my mind. Also none of the other keys are abbreviated. Just looks wrong.
vadimdemedes
force-pushed
the
event-improvements
branch
from
c57193c to
ac832d1
Compare
|
Clean code is happy code :D |
|
Couldn't agree more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lays groundwork for #132 and #192 by allowing to easily send & receive custom test properties.