Add ava modules to test module paths #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is compatible with npm@3, though. As it could put |
| @@ -2,6 +2,7 @@ | |||
| var resolveFrom = require('resolve-from'); | |||
| var createEspowerPlugin = require('babel-plugin-espower/create'); | |||
| var requireFromString = require('require-from-string'); | |||
| var resolve = require('path').resolve; | |||
There was a problem hiding this comment.
I usually prefer to import the full module.
var path = require('path');
|
You also need to bump |
floatdrop
force-pushed
the
add-ava-modules-to-test-module-paths
branch
from
1786c69 to
46e33ed
Compare
floatdrop
force-pushed
the
add-ava-modules-to-test-module-paths
branch
from
46e33ed to
de0955b
Compare
|
Fixed. |
sindresorhus
added a commit
that referenced
this pull request
Nov 7, 2015
…-paths Add ava modules to test module paths
Closed
|
Awesome! Thanks for working on this and resolving it so quickly @floatdrop :) Continues in: #152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drawback - now you can require any module from
ava/node_modulein tests.Closes #144