Wait for fork to exit and then return results #136
Conversation
|
That should do it. |
| // define backup results, when there are no tests defined | ||
| var testResults = { | ||
| stats: { | ||
| passCount: 0 |
There was a problem hiding this comment.
Does ava already warn if a test file has no tests? (i.e. passCount === 0)?
I would think that should be a failure, otherwise putting:
process.exit(0); at the top of your test makes it pass. (contrived I know).
Should we be warning if the process exits with code 0, but never sends a result message?
There was a problem hiding this comment.
I think I will revert this one, because it seems unrelated to this PR. I think this question deserves its own space.
There was a problem hiding this comment.
I would agree, it needs a separate issue/discussion.
I think your code is fine, no need to revert. Lets just create a new issue and follow up on it.
There was a problem hiding this comment.
@vdemedes #137 created to track that discussion.
There was a problem hiding this comment.
I will revert it, just for the sake of keeping things clear.
vadimdemedes
force-pushed
the
wait-for-forks
branch
from
ff8df79 to
1d01665
Compare
Wait for fork to exit and then return results
Improves #134.
// @jamestalmage