Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add failing test demonstrating long running onExit() hook in child process #135

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -90,6 +90,7 @@
"devDependencies": {
"coveralls": "^2.11.4",
"nyc": "^3.2.2",
"signal-exit": "^2.1.2",
"tap-dot": "^1.0.0",
"tape": "^4.0.0",
"xo": "*"
17 changes: 15 additions & 2 deletions test/fixture/long-running.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,25 @@
'use strict';
const test = require('../../');
var onExit = require('signal-exit');

test('long running', function (t) {
t.plan(1);

onExit(function () {
// simulate an exit hook that lasts a short while
var start = Date.now();
while(Date.now() - start < 2000) {
//synchronously wait for 2 seconds
}
process.send({name:'cleanup-completed', data: {completed: true}});
}, {alwaysLast: true});

setTimeout(function () {
t.ok(true);
});

setTimeout(function () {
// this would keep the process running for a long time.
console.log('I\'m gonna live forever!!');
}, 15000);

t.ok(true);
});
9 changes: 7 additions & 2 deletions test/fork.js
Original file line number Diff line number Diff line change
@@ -41,12 +41,17 @@ test('rejects on error and streams output', function (t) {
});

test('exit after tests are finished', function (t) {
t.plan(1);
t.plan(2);

var start = Date.now();
var cleanupCompleted = false;

fork(fixture('long-running.js'))
.on('exit', function () {
t.ok(Date.now() - start < 10000);
t.ok(Date.now() - start < 10000, 'did NOT wait for setTimeout(fn, 15000');
t.ok(cleanupCompleted, 'did wait for onExit(fn) to complete');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these assertion messages are bad. I should fix them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are error messages, they are displayed when assertion fails.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, race condition :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right - I've got them in the affirmative ('did NOT wait for setTimeout(fn, 15000')') -that is actually what we want (do not wait 15 seconds).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamestalmage I've added Windows testing with AppVeyor and this assertion fails: https://ci.appveyor.com/project/sindresorhus/ava/build/2/job/w7efao2if7n2g2q9 Could you take a look?

})
.on('cleanup-completed', function (event) {
cleanupCompleted = event.completed;
});
});