Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Customizer instead of Bootstrap Config #71

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

SentryMan
Copy link
Collaborator

It occurs to me that using Bootstrap (which runs immediately before every other form of config) runs the risk of having its configurations overwritten by the inject plugin causing some perhaps unexpected results. I'm thinking to make the primary way of configuring the validator (outside of directly calling the builder functions) be via the customizer interface.

  • rename ValidatorComponent to ValidatorCustomizer (I just think it sounds cooler and is more descriptive)
  • remove the bootstrap interface
  • adds an annotation to automatically add ValidatorCustomizer entries to the services file

@rbygrave rbygrave merged commit 0839d48 into avaje:main Jul 13, 2023
@rbygrave rbygrave added this to the 0.10 milestone Jul 13, 2023
@SentryMan SentryMan deleted the customizer branch July 13, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants