Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param Validation Aspect #65

Merged
merged 42 commits into from
Jul 7, 2023
Merged

Param Validation Aspect #65

merged 42 commits into from
Jul 7, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Jul 4, 2023

  • rename ValidPojo to Valid
  • adds a basic plugin module with aspect for method validation
  • adds a param validation class that takes a validator and adaptor providers
  • generator modified to detect when to aspect is used and generate helper classes
  • generator will annotate the first helper class with @Component.Import(ParamValidator). this is so that user provided validators can work out of the box
  • no longer need to escape parenthesis

relies on #63 (hence the massive file count) fixes #64

@SentryMan
Copy link
Collaborator Author

hmm, it works on my local

@SentryMan SentryMan marked this pull request as draft July 4, 2023 14:55
@SentryMan SentryMan marked this pull request as ready for review July 5, 2023 03:20
@SentryMan
Copy link
Collaborator Author

SentryMan commented Jul 5, 2023

We need to have avaje/avaje-inject#363 deployed before tests can pass.

EDIT: well I guess it was already deployed

@SentryMan
Copy link
Collaborator Author

I'm good with this now

@rbygrave rbygrave merged commit 5536f55 into avaje:main Jul 7, 2023
@SentryMan SentryMan deleted the param branch July 7, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method Parameter Validation (via Avaje Inject AOP)
2 participants